Tickets :: Comment on [#209] rosterFilled() calls notifyOnConnect()

* Your Email Address
* Spam protection	Enter the letters below: __ __ _ ___ ___ _ _____ \| \/ \| \| \| \ \ / / \| \| \|/ ____\| \| \ / \| \|__\| \|\ \ /\ / /\| \|__\| \| \| \| \|\/\| \| __ \| \ \/ \/ / \| __ \| \| \| \| \| \| \| \| \| \ /\ / \| \| \| \| \|____ \|_\| \|_\|_\| \|_\| \/ \/ \|_\| \|_\|\_____\|
Comment	> Hi there, > > I have realized that rosterFilled() calls notifyOnConnect(). In my > opinion, that is confusing since rosterManager()->fill() is public so > I can call that method who will also call notifyOnConnect(). I mean, > onConnect() handler will be called again even if I am already > connected to the server. > > I think the best approach consist in putting notifyOnConnect(); as > the final line of Client::connected() removing the previous call, and > also removing notifyOnConnect() from rosterFilled(). > > Maybe I am not right but anyway I think it's confusing! :) > > Cheers, > Dídac
Attachment
Watch this ticket