I have realized that rosterFilled() calls notifyOnConnect(). In my
opinion, that is confusing since rosterManager()->fill() is public so
I can call that method who will also call notifyOnConnect(). I mean,
onConnect() handler will be called again even if I am already
connected to the server.
I think the best approach consist in putting notifyOnConnect(); as the
final line of Client::connected() removing the previous call, and also
removing notifyOnConnect() from rosterFilled().
Maybe I am not right but anyway I think it's confusing! :)
State ⇒ Unconfirmed
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ rosterFilled() calls notifyOnConnect()
Queue ⇒ gloox
I have realized that rosterFilled() calls notifyOnConnect(). In my
opinion, that is confusing since rosterManager()->fill() is public so
I can call that method who will also call notifyOnConnect(). I mean,
onConnect() handler will be called again even if I am already
connected to the server.
I think the best approach consist in putting notifyOnConnect(); as the
final line of Client::connected() removing the previous call, and also
removing notifyOnConnect() from rosterFilled().
Maybe I am not right but anyway I think it's confusing! :)
Cheers,
DÃdac