5.2.20
12/08/2019

[#209] rosterFilled() calls notifyOnConnect()
Summary rosterFilled() calls notifyOnConnect()
Queue gloox
Queue Version 1.0.3
Type Bug
State Unconfirmed
Priority 2. Medium
Owners
Requester perez.didac (at) gmail (dot) com
Created 07/24/2013 (2328 days ago)
Due
Updated
Assigned
Resolved

History
07/24/2013 10:33:37 AM perez (dot) didac (at) gmail (dot) com Comment #1
State ⇒ Unconfirmed
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ rosterFilled() calls notifyOnConnect()
Queue ⇒ gloox
Reply to this comment
Hi there,

I have realized that rosterFilled() calls notifyOnConnect(). In my 
opinion, that is confusing since rosterManager()->fill() is public so 
I can call that method who will also call notifyOnConnect(). I mean, 
onConnect() handler will be called again even if I am already 
connected to the server.

I think the best approach consist in putting notifyOnConnect(); as the 
final line of Client::connected() removing the previous call, and also 
removing notifyOnConnect() from rosterFilled().

Maybe I am not right but anyway I think it's confusing! :)

Cheers,
Dídac